Skip to content

SDL3 runtime fixes mega PR #3562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

SDL3 runtime fixes mega PR #3562

wants to merge 5 commits into from

Conversation

ankith26
Copy link
Member

This is a draft mega PR where I will test all my SDL3 related runtime fixes in integration.

Once this PR is done from my side, I will break this PR into a series of sub PRs that tackle things individually for ease of review. This PR will then be repurposed to run all tests on SDL3 CI and then should be merged after all the sub PRs.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 18, 2025 •
edited
Loading

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ankith26-sdl3-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ankith26 ankith26 force-pushed the ankith26-sdl3-fixes branch 5 times, most recently from b57fa06 to ebcd733 Compare August 21, 2025 08:51
@ankith26 ankith26 mentioned this pull request Aug 28, 2025
Merged
@Starbuck5 Starbuck5 added the sdl3 label Aug 30, 2025
@ankith26 ankith26 force-pushed the ankith26-sdl3-fixes branch 7 times, most recently from e107563 to 1cdc4f0 Compare September 1, 2025 12:52
@ankith26 ankith26 force-pushed the ankith26-sdl3-fixes branch from 1cdc4f0 to 51a6e98 Compare September 3, 2025 16:00
@ankith26 ankith26 force-pushed the ankith26-sdl3-fixes branch from 51a6e98 to 3f8f9a8 Compare September 3, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
sdl3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankith26 @Starbuck5